Skip to content

feat: include game monitor type in status page monitor selection #3050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat: include game monitor type in status page monitor selection #3050

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/src/Pages/v1/StatusPage/Create/Hooks/useMonitorsFetch.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const useMonitorsFetch = () => {
try {
const response = await networkService.getMonitorsByTeamId({
limit: null, // donot return any checks for the monitors
types: ["http", "ping", "port"], // status page is available for uptime, ping, and port monitors
types: ["http", "ping", "port", "game"], // include game servers in status page monitor selection
});
Comment on lines 15 to 18
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 | Confidence: High

  • The hardcoded array of monitor types creates maintenance risk, as future additions would require manual updates across multiple locations, potentially leading to inconsistencies. Consider defining monitor types in a shared constants file for better maintainability.
  • The updated comment removes previous context about supported monitor types, reducing clarity for future maintainers. Suggest updating the comment to include all supported types for better documentation.

setMonitors(response.data.data.monitors);
} catch (error) {
Expand Down