feat(root-cms): use batch requests for route docs #768
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| const shouldLoadTranslations = siteLocales.length > 1; | ||
| if (shouldLoadTranslations) { | ||
| translationsTags.forEach((tag) => { | ||
| if (tag !== docTranslationsId) { | ||
| batchRequest.addTranslations(tag); | ||
| } |
There was a problem hiding this comment.
[P1] SSG skips translations when only one locale configured
The new batch request logic now gates translation fetching behind siteLocales.length > 1, so single‑locale static builds no longer load their common or doc translations and return {} from generateProps. Previously getStaticProps always loaded translations regardless of the number of locales, meaning single‑locale sites still received the localized strings for their default language. This regression will cause translation helpers to miss strings on SSG pages for single‑locale sites. Consider always fetching the configured translation tags for SSG or restoring the previous behaviour so one‑locale sites keep their translations.
Useful? React with 👍 / 👎.
Summary
BatchRequestto theRouteContextprovided bycreateRouteTesting
https://chatgpt.com/codex/tasks/task_e_68d44b3855c48323a7dec7ba4e8a5a68