[8.5.0] Allow fulfilled nodep edges to influence version selection #27478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Enforce via the type system that a resolution strategy can't change the module name. * Use a wither instead of the constructor to avoid losing information when changing the version of a `DepSpec`. This will be used as a base for simplifications to the selection algorithm, whose runtime is currently exponential in the number of deps with non-trivial `max_compatibility_level`. Along the way, fix an error message and add test cases. Closes bazelbuild#26573. PiperOrigin-RevId: 797428276 Change-Id: I1a3020ae14172140ce59332cbac79ea18fad1a86
Previously, nodep edges were simply ignored during version selection, even if "fulfilled" (as in, another version of the dependency exists somewhere else in the graph). Their effect was only visible because they made more modules show up in the unresolved dependency graph, causing MVS to pick them up. But this meant that when `max_compatibility_level` was involved, we might get surprising results. Now we also take fulfilled nodep edges into account during version selection. Most importantly, the post-selection graph walk now takes nodep edges into account, meaning that any existing `max_compatibility_level` dep is forced to upgrade to ensure that only one version remains in the final graph. Fixes bazelbuild#27441. PiperOrigin-RevId: 826401269 Change-Id: I2a0970b409adfe0b42456a54dbd626fc63a1523a
github-actions
bot
added
team-ExternalDeps
Wyverald
approved these changes
Oct 31, 2025
Merged
via the queue into
bazelbuild:release-8.5.0
with commit Oct 31, 2025
170892f
47 checks passed
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, nodep edges were simply ignored during version selection, even if "fulfilled" (as in, another version of the dependency exists somewhere else in the graph). Their effect was only visible because they made more modules show up in the unresolved dependency graph, causing MVS to pick them up. But this meant that when
max_compatibility_levelwas involved, we might get surprising results.Now we also take fulfilled nodep edges into account during version selection. Most importantly, the post-selection graph walk now takes nodep edges into account, meaning that any existing
max_compatibility_leveldep is forced to upgrade to ensure that only one version remains in the final graph.Fixes #27441.
PiperOrigin-RevId: 826401269
Change-Id: I2a0970b409adfe0b42456a54dbd626fc63a1523a
Also backported e327c1b
Closes #27477