Skip to content

Conversation

@peterrsongg
Copy link
Contributor

@peterrsongg peterrsongg commented Nov 4, 2025

Description

I'm splitting this pr which contains all 4 operations into smaller PRs.

This one contains changes for PutBucketMetricsConfiguration and it also moves some code for PutLifecyclecConfiguration to a custom partial instead of trying to generate these visitor pattern apis via a class in Customizations.json.

Best way to review is by pulling up the custom version of the file on one side and the generated version of the file on the other side and compare.

Motivation and Context

Generates PutBucketMetricsConfiguration

Testing

The branch in other PR has been dry run.
Fuzz tests have been run
assembly comparer has been run
AI prompt has been run

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

License

  • I confirm that this pull request can be released under the Apache 2 license

@peterrsongg peterrsongg closed this Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant