-
Notifications
You must be signed in to change notification settings - Fork 152
Implement more options for req CLI #2775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There were too many comments to post at once. Showing the first 10 out of 11. Check the log or trigger a new build to see more.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2775 +/- ##
========================================
Coverage 78.42% 78.43%
========================================
Files 683 683
Lines 116286 117174 +888
Branches 16402 16478 +76
========================================
+ Hits 91198 91900 +702
- Misses 24212 24391 +179
- Partials 876 883 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
b504f7e to
6a32876
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
justsmth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov shows most of req.cc as not being covered -- the logic seems to be mostly covered by comparison tests, but apparently not by unit tests. We should have unit tests to provide better coverage and possibly hit a few edge cases that aren't easily covered by comparisons.
|
Also a couple of the Openssl comparison tests are failing for this: |
7727746 to
5d2bc29
Compare
Issues:
Resolves #CryptoAlg-3380
Description of changes:
Implement the following options for x509 cli command:
Testing:
Unit tests added, including missing coverage for some existing x509 options.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.