Skip to content

fix: ignore errors when vpc does not have default security groups #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: ignore errors when vpc does not have default security groups #296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
385c77b
fix: ignore errors when vpc does not have default security groups
michaelhtm Nov 3, 2025
887d501
generate ec2 with latest code-gen
michaelhtm Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions apis/v1alpha1/ack-generate-metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
ack_generate_info:
build_date: "2025-09-25T16:19:07Z"
build_hash: 6b4211163dcc34776b01da9a18217bac0f4103fd
go_version: go1.24.6
version: v0.52.0
build_date: "2025-11-03T23:59:47Z"
build_hash: eaabefb6bd7b2be8a1baf4478f22b3310e6921c8
go_version: go1.25.1
version: v0.52.0-6-geaabefb
api_directory_checksum: 5a5c93e3d4865ea08d8a47b2500551112ea831b9
api_version: v1alpha1
aws_sdk_go_version: v1.32.6
generator_config_info:
file_checksum: 6d72b2e7d053535b6f6966348d3ac4e4535052cd
file_checksum: 220d17205c72ce425824ef99e0a79fbfc7c63ef2
original_file_name: generator.yaml
last_modification:
reason: API generation
2 changes: 1 addition & 1 deletion config/crd/bases/ec2.services.k8s.aws_capacityreservations.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.2
controller-gen.kubebuilder.io/version: v0.19.0
name: capacityreservations.ec2.services.k8s.aws
spec:
group: ec2.services.k8s.aws
Expand Down
2 changes: 1 addition & 1 deletion config/crd/bases/ec2.services.k8s.aws_dhcpoptions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.2
controller-gen.kubebuilder.io/version: v0.19.0
name: dhcpoptions.ec2.services.k8s.aws
spec:
group: ec2.services.k8s.aws
Expand Down
2 changes: 1 addition & 1 deletion config/crd/bases/ec2.services.k8s.aws_elasticipaddresses.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.2
controller-gen.kubebuilder.io/version: v0.19.0
name: elasticipaddresses.ec2.services.k8s.aws
spec:
group: ec2.services.k8s.aws
Expand Down
2 changes: 1 addition & 1 deletion config/crd/bases/ec2.services.k8s.aws_flowlogs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.2
controller-gen.kubebuilder.io/version: v0.19.0
name: flowlogs.ec2.services.k8s.aws
spec:
group: ec2.services.k8s.aws
Expand Down
2 changes: 1 addition & 1 deletion config/crd/bases/ec2.services.k8s.aws_instances.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.2
controller-gen.kubebuilder.io/version: v0.19.0
name: instances.ec2.services.k8s.aws
spec:
group: ec2.services.k8s.aws
Expand Down
2 changes: 1 addition & 1 deletion config/crd/bases/ec2.services.k8s.aws_internetgateways.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.2
controller-gen.kubebuilder.io/version: v0.19.0
name: internetgateways.ec2.services.k8s.aws
spec:
group: ec2.services.k8s.aws
Expand Down
2 changes: 1 addition & 1 deletion config/crd/bases/ec2.services.k8s.aws_launchtemplates.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.2
controller-gen.kubebuilder.io/version: v0.19.0
name: launchtemplates.ec2.services.k8s.aws
spec:
group: ec2.services.k8s.aws
Expand Down
2 changes: 1 addition & 1 deletion config/crd/bases/ec2.services.k8s.aws_natgateways.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.2
controller-gen.kubebuilder.io/version: v0.19.0
name: natgateways.ec2.services.k8s.aws
spec:
group: ec2.services.k8s.aws
Expand Down
2 changes: 1 addition & 1 deletion config/crd/bases/ec2.services.k8s.aws_networkacls.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.2
controller-gen.kubebuilder.io/version: v0.19.0
name: networkacls.ec2.services.k8s.aws
spec:
group: ec2.services.k8s.aws
Expand Down
2 changes: 1 addition & 1 deletion config/crd/bases/ec2.services.k8s.aws_routetables.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.2
controller-gen.kubebuilder.io/version: v0.19.0
name: routetables.ec2.services.k8s.aws
spec:
group: ec2.services.k8s.aws
Expand Down
2 changes: 1 addition & 1 deletion config/crd/bases/ec2.services.k8s.aws_securitygroups.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.2
controller-gen.kubebuilder.io/version: v0.19.0
name: securitygroups.ec2.services.k8s.aws
spec:
group: ec2.services.k8s.aws
Expand Down
2 changes: 1 addition & 1 deletion config/crd/bases/ec2.services.k8s.aws_subnets.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.2
controller-gen.kubebuilder.io/version: v0.19.0
name: subnets.ec2.services.k8s.aws
spec:
group: ec2.services.k8s.aws
Expand Down
2 changes: 1 addition & 1 deletion config/crd/bases/ec2.services.k8s.aws_transitgateways.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.2
controller-gen.kubebuilder.io/version: v0.19.0
name: transitgateways.ec2.services.k8s.aws
spec:
group: ec2.services.k8s.aws
Expand Down
2 changes: 1 addition & 1 deletion config/crd/bases/ec2.services.k8s.aws_transitgatewayvpcattachments.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.2
controller-gen.kubebuilder.io/version: v0.19.0
name: transitgatewayvpcattachments.ec2.services.k8s.aws
spec:
group: ec2.services.k8s.aws
Expand Down
2 changes: 1 addition & 1 deletion config/crd/bases/ec2.services.k8s.aws_vpcendpoints.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.2
controller-gen.kubebuilder.io/version: v0.19.0
name: vpcendpoints.ec2.services.k8s.aws
spec:
group: ec2.services.k8s.aws
Expand Down
2 changes: 1 addition & 1 deletion config/crd/bases/ec2.services.k8s.aws_vpcendpointserviceconfigurations.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.2
controller-gen.kubebuilder.io/version: v0.19.0
name: vpcendpointserviceconfigurations.ec2.services.k8s.aws
spec:
group: ec2.services.k8s.aws
Expand Down
2 changes: 1 addition & 1 deletion config/crd/bases/ec2.services.k8s.aws_vpcpeeringconnections.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.2
controller-gen.kubebuilder.io/version: v0.19.0
name: vpcpeeringconnections.ec2.services.k8s.aws
spec:
group: ec2.services.k8s.aws
Expand Down
2 changes: 1 addition & 1 deletion config/crd/bases/ec2.services.k8s.aws_vpcs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.2
controller-gen.kubebuilder.io/version: v0.19.0
name: vpcs.ec2.services.k8s.aws
spec:
group: ec2.services.k8s.aws
Expand Down
2 changes: 1 addition & 1 deletion helm/crds/ec2.services.k8s.aws_capacityreservations.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.2
controller-gen.kubebuilder.io/version: v0.19.0
name: capacityreservations.ec2.services.k8s.aws
spec:
group: ec2.services.k8s.aws
Expand Down
2 changes: 1 addition & 1 deletion helm/crds/ec2.services.k8s.aws_dhcpoptions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.2
controller-gen.kubebuilder.io/version: v0.19.0
name: dhcpoptions.ec2.services.k8s.aws
spec:
group: ec2.services.k8s.aws
Expand Down
2 changes: 1 addition & 1 deletion helm/crds/ec2.services.k8s.aws_elasticipaddresses.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.2
controller-gen.kubebuilder.io/version: v0.19.0
name: elasticipaddresses.ec2.services.k8s.aws
spec:
group: ec2.services.k8s.aws
Expand Down
2 changes: 1 addition & 1 deletion helm/crds/ec2.services.k8s.aws_flowlogs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.2
controller-gen.kubebuilder.io/version: v0.19.0
name: flowlogs.ec2.services.k8s.aws
spec:
group: ec2.services.k8s.aws
Expand Down
2 changes: 1 addition & 1 deletion helm/crds/ec2.services.k8s.aws_instances.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.2
controller-gen.kubebuilder.io/version: v0.19.0
name: instances.ec2.services.k8s.aws
spec:
group: ec2.services.k8s.aws
Expand Down
2 changes: 1 addition & 1 deletion helm/crds/ec2.services.k8s.aws_internetgateways.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.2
controller-gen.kubebuilder.io/version: v0.19.0
name: internetgateways.ec2.services.k8s.aws
spec:
group: ec2.services.k8s.aws
Expand Down
2 changes: 1 addition & 1 deletion helm/crds/ec2.services.k8s.aws_launchtemplates.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.2
controller-gen.kubebuilder.io/version: v0.19.0
name: launchtemplates.ec2.services.k8s.aws
spec:
group: ec2.services.k8s.aws
Expand Down
2 changes: 1 addition & 1 deletion helm/crds/ec2.services.k8s.aws_natgateways.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.2
controller-gen.kubebuilder.io/version: v0.19.0
name: natgateways.ec2.services.k8s.aws
spec:
group: ec2.services.k8s.aws
Expand Down
2 changes: 1 addition & 1 deletion helm/crds/ec2.services.k8s.aws_networkacls.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.2
controller-gen.kubebuilder.io/version: v0.19.0
name: networkacls.ec2.services.k8s.aws
spec:
group: ec2.services.k8s.aws
Expand Down
2 changes: 1 addition & 1 deletion helm/crds/ec2.services.k8s.aws_routetables.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.2
controller-gen.kubebuilder.io/version: v0.19.0
name: routetables.ec2.services.k8s.aws
spec:
group: ec2.services.k8s.aws
Expand Down
2 changes: 1 addition & 1 deletion helm/crds/ec2.services.k8s.aws_securitygroups.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.2
controller-gen.kubebuilder.io/version: v0.19.0
name: securitygroups.ec2.services.k8s.aws
spec:
group: ec2.services.k8s.aws
Expand Down
2 changes: 1 addition & 1 deletion helm/crds/ec2.services.k8s.aws_subnets.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.2
controller-gen.kubebuilder.io/version: v0.19.0
name: subnets.ec2.services.k8s.aws
spec:
group: ec2.services.k8s.aws
Expand Down
2 changes: 1 addition & 1 deletion helm/crds/ec2.services.k8s.aws_transitgateways.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.2
controller-gen.kubebuilder.io/version: v0.19.0
name: transitgateways.ec2.services.k8s.aws
spec:
group: ec2.services.k8s.aws
Expand Down
2 changes: 1 addition & 1 deletion helm/crds/ec2.services.k8s.aws_transitgatewayvpcattachments.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.2
controller-gen.kubebuilder.io/version: v0.19.0
name: transitgatewayvpcattachments.ec2.services.k8s.aws
spec:
group: ec2.services.k8s.aws
Expand Down
2 changes: 1 addition & 1 deletion helm/crds/ec2.services.k8s.aws_vpcendpoints.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.2
controller-gen.kubebuilder.io/version: v0.19.0
name: vpcendpoints.ec2.services.k8s.aws
spec:
group: ec2.services.k8s.aws
Expand Down
2 changes: 1 addition & 1 deletion helm/crds/ec2.services.k8s.aws_vpcendpointserviceconfigurations.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.2
controller-gen.kubebuilder.io/version: v0.19.0
name: vpcendpointserviceconfigurations.ec2.services.k8s.aws
spec:
group: ec2.services.k8s.aws
Expand Down
2 changes: 1 addition & 1 deletion helm/crds/ec2.services.k8s.aws_vpcpeeringconnections.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.2
controller-gen.kubebuilder.io/version: v0.19.0
name: vpcpeeringconnections.ec2.services.k8s.aws
spec:
group: ec2.services.k8s.aws
Expand Down
2 changes: 1 addition & 1 deletion helm/crds/ec2.services.k8s.aws_vpcs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.2
controller-gen.kubebuilder.io/version: v0.19.0
name: vpcs.ec2.services.k8s.aws
spec:
group: ec2.services.k8s.aws
Expand Down
2 changes: 1 addition & 1 deletion helm/crds/services.k8s.aws_adoptedresources.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.2
controller-gen.kubebuilder.io/version: v0.19.0
name: adoptedresources.services.k8s.aws
spec:
group: services.k8s.aws
Expand Down
2 changes: 1 addition & 1 deletion helm/crds/services.k8s.aws_fieldexports.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.2
controller-gen.kubebuilder.io/version: v0.19.0
name: fieldexports.services.k8s.aws
spec:
group: services.k8s.aws
Expand Down
1 change: 0 additions & 1 deletion pkg/resource/instance/hooks.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,6 @@ func needsRestart(ko *v1alpha1.Instance) bool {
return *ko.Status.State.Name == string(svcsdktypes.InstanceStateNameTerminated)
}


func setAdditionalFields(instance svcsdktypes.Instance, ko *v1alpha1.Instance) {
ko.Spec.SecurityGroupIDs = []*string{}
for _, group := range instance.SecurityGroups {
Expand Down
Loading