-
Notifications
You must be signed in to change notification settings - Fork 26
feat: Add annotation to tweak providedThroughput control for tables #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pbarsotti-glovo The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @pbarsotti-glovo. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
@pbarsotti-glovo: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
hey @a-hilaly the codgen diff in the version could be due to my |
|
For DynamoDB Tables we have multiple fields where provisioned throughput values are defined and can be managed externally. For example, |
I thought that could be better to handle each one independently, although following the same approach. That's why I put |
Issue 2032.
Description of changes:
Following the line of what was implemented for NodeGroups in this PR, the idea is to allow users to indicate via an annotation if the provisioned throughput of a table is managed by ACK's controller or if an external autoscaler is adapting the capacity dynamically.
In case of external autoscaler, the provisioned throughput defined in the spec is ignored during the delta creation phase to avoid updating these values, which could result in a sudden loss of capacity.