Update readme to specify virtual threads requirement
#321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify that virtual threads aren't just a default or suggestion, but a hard requirement. Related-to: avaje#320 (comment) Signed-off-by: Mahied Maruf <contact@mechite.com>
Collaborator
|
Probably better to say that we lack async in favor of virtual threads |
Related-to: avaje#321 (comment) Signed-off-by: Mahied Maruf <contact@mechite.com>
Contributor
|
I'd probably just leave the docs as is personally.
People can actually do whatever they like with the request handling ... it's more that jex is just the ExecutorService executing the request/response [without any event loop / async nio etc] and that defaults to using Virtual Threads. I think trying to say that as "no Future-based programming model" isn't making that clearer and in fact will confuse some people. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify that virtual threads aren't just a default or suggestion,
but a hard requirement.
Related-to: #320 (comment)
Signed-off-by: Mahied Maruf contact@mechite.com