feat: Add UpdateSyncTarget to registry #1346
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This adds a lot of the synchronization logic necessary for ensuring UpdateSyncTarget can only be called at the correct times. Note that deciding when to call UpdateSyncTarget is not within scope for the registry.
Closes #1343
How this works
Tracks the current target for the syncers, as well as adds stubs for the UpdateSyncTarget implementations (see comments) and the finalization logic #1344
How this was tested
New UT
Need to be documented?
No.
Need to update RELEASES.md?
No.