Verify After Receiving Empty Notarizations #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sam Liokumovich <65994425+samliok@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enforces that blocks are only verified if their parent digests are verified(notarized or finalized) as well as any empty notarizations that are in between the parent and the to be verified block.
It does so by adjusting the scheduler to wait for two dependencies to be resolved: the parent digest, and any missing empty notarizations. When empty notarizations get persisted, we notify the scheduler. To do so, we must allow empty notarizations from previous rounds to be processed and ensure we don't delete empty notarizations from memory prematurely.
In a future PR, I will add the ability for a node to request these missing empty notarizations.