Skip to content

Conversation

@arusatech
Copy link
Owner

Fixes a log listener removal bug, aligns Android session and completion parameter names with TypeScript, and normalizes saveSession return handling.

This PR addresses three distinct issues:

  1. Log Listener Removal: The addNativeLogListener's remove function could incorrectly remove the last listener if the target listener was already absent, due to Array#indexOf returning -1.
  2. Android Session API Mismatch: Android's loadSession and saveSession expected a path parameter, while the TypeScript API provided filepath, leading to session operations failing. The saveSession return in TS is also normalized for robustness.
  3. Android Completion Parameter Mismatch: The Android completion method expected a temp parameter, but the TypeScript API sent temperature, causing the temperature setting to be ignored.

Open in Cursor Open in Web

Co-authored-by: arusatechnology <arusatechnology@gmail.com>
@cursor
Copy link

cursor bot commented Sep 6, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@arusatech arusatech marked this pull request as ready for review September 6, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants