JUnit Jupiter best practices

src/test/java/org/apache/maven/buildcache/BuildCacheMojosExecutionStrategyTest.java

@@ -72,7 +72,7 @@ void setUp() {
         }
 
         @Test
-        void testBasicParamsMatching() {
+        void basicParamsMatching() {
 
             boolean windows = SystemUtils.IS_OS_WINDOWS;
 
@@ -110,7 +110,7 @@ void testBasicParamsMatching() {
         }
 
         @Test
-        void testSkipValue() {
+        void skipValue() {
 
             String propertyName = "anyObject";
 
@@ -139,7 +139,7 @@ void testSkipValue() {
         }
 
         @Test
-        void testDefaultValue() {
+        void defaultValue() {
 
             String propertyName = "anyObject";
 
@@ -167,7 +167,7 @@ void testDefaultValue() {
         }
 
         @Test
-        void testMismatch() {
+        void mismatch() {
 
             String propertyName = "anyObject";
 

src/test/java/org/apache/maven/buildcache/CacheUtilsPermissionsTest.java

@@ -50,7 +50,7 @@ class CacheUtilsPermissionsTest {
      * cache correctness similar to how Git includes file mode in tree hashes.
      */
     @Test
-    void testPermissionsAffectFileHashWhenEnabled() throws IOException {
+    void permissionsAffectFileHashWhenEnabled() throws Exception {
         // Skip test on non-POSIX filesystems (e.g., Windows)
         if (!tempDir.getFileSystem().supportedFileAttributeViews().contains("posix")) {
             return;
@@ -100,7 +100,7 @@ void testPermissionsAffectFileHashWhenEnabled() throws IOException {
      * the key point is that permission information is NOT deterministically stored.
      */
     @Test
-    void testPermissionsDoNotAffectHashWhenDisabled() throws IOException {
+    void permissionsDoNotAffectHashWhenDisabled() throws Exception {
         // Skip test on non-POSIX filesystems (e.g., Windows)
         if (!tempDir.getFileSystem().supportedFileAttributeViews().contains("posix")) {
             return;

src/test/java/org/apache/maven/buildcache/LifecyclePhasesHelperTest.java

@@ -158,17 +158,14 @@ void isLaterPhase() {
         assertFalse(lifecyclePhasesHelper.isLaterPhase("test", "site"));
         assertFalse(lifecyclePhasesHelper.isLaterPhase("clean", "site"));
 
-        assertThrows(IllegalArgumentException.class, () -> {
-            lifecyclePhasesHelper.isLaterPhase("install", null);
-        });
+        assertThrows(IllegalArgumentException.class, () ->
+            lifecyclePhasesHelper.isLaterPhase("install", null));
 
-        assertThrows(IllegalArgumentException.class, () -> {
-            lifecyclePhasesHelper.isLaterPhase("install", "unknown phase");
-        });
+        assertThrows(IllegalArgumentException.class, () ->
+            lifecyclePhasesHelper.isLaterPhase("install", "unknown phase"));
 
-        assertThrows(IllegalArgumentException.class, () -> {
-            lifecyclePhasesHelper.isLaterPhase("unknown phase", "install");
-        });
+        assertThrows(IllegalArgumentException.class, () ->
+            lifecyclePhasesHelper.isLaterPhase("unknown phase", "install"));
     }
 
     @Test
@@ -225,7 +222,7 @@ void getCleanSegmentForkedAnyLifecyclePhase() {
     }
 
     @Test
-    void testCachedSegment() {
+    void cachedSegment() {
         MojoExecution compile = mockedMojoExecution("compile");
         MojoExecution test = mockedMojoExecution("test");
         List<MojoExecution> mojoExecutions = Arrays.asList(compile, test, mockedMojoExecution("install"));
@@ -239,7 +236,7 @@ void testCachedSegment() {
     }
 
     @Test
-    void testEmptyCachedSegment() {
+    void emptyCachedSegment() {
         MojoExecution compile = mockedMojoExecution("compile");
         MojoExecution test = mockedMojoExecution("test");
         MojoExecution install = mockedMojoExecution("install");
@@ -254,7 +251,7 @@ void testEmptyCachedSegment() {
     }
 
     @Test
-    void testCachedSegmentForked() {
+    void cachedSegmentForked() {
         MojoExecution me1 = mockedMojoExecution(null);
         MojoExecution me2 = mockedMojoExecution(null);
 
@@ -273,7 +270,7 @@ void testCachedSegmentForked() {
 
     @ParameterizedTest
     @ValueSource(strings = {"install", "site"})
-    void testAllInCachedSegment() {
+    void allInCachedSegment() {
         MojoExecution compile = mockedMojoExecution("compile");
         MojoExecution test = mockedMojoExecution("test");
         MojoExecution install = mockedMojoExecution("install");
@@ -288,7 +285,7 @@ void testAllInCachedSegment() {
     }
 
     @Test
-    void testPostCachedSegment() {
+    void postCachedSegment() {
         MojoExecution compile = mockedMojoExecution("compile");
         MojoExecution test = mockedMojoExecution("test");
         MojoExecution install = mockedMojoExecution("install");
@@ -304,7 +301,7 @@ void testPostCachedSegment() {
     }
 
     @Test
-    void testAllPostCachedSegment() {
+    void allPostCachedSegment() {
         MojoExecution compile = mockedMojoExecution("compile");
         MojoExecution test = mockedMojoExecution("test");
         MojoExecution install = mockedMojoExecution("install");
@@ -320,7 +317,7 @@ void testAllPostCachedSegment() {
     }
 
     @Test
-    void testPostCachedSegmentForked() {
+    void postCachedSegmentForked() {
         MojoExecution me1 = mockedMojoExecution(null);
         MojoExecution me2 = mockedMojoExecution(null);
 
@@ -340,7 +337,7 @@ void testPostCachedSegmentForked() {
 
     @ParameterizedTest
     @ValueSource(strings = {"install", "site"})
-    void testEmptyPostCachedSegmentInclusive() {
+    void emptyPostCachedSegmentInclusive() {
         MojoExecution compile = mockedMojoExecution("compile");
         MojoExecution test = mockedMojoExecution("test");
         MojoExecution install = mockedMojoExecution("install");