MINOR: Fix --fetch-size description in ConsumerPerformance #20835
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankYang0529
approved these changes
Nov 6, 2025
Member
FrankYang0529
left a comment
FrankYang0529
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the patch.
Yunyung
approved these changes
Nov 6, 2025
m1a2st
approved these changes
Nov 6, 2025
Member
|
@mingyen066 could you please also update the following file ? |
Collaborator
Author
|
@chia7712 Sure, updated. |
eduwercamacaro
pushed a commit
to littlehorse-enterprises/kafka
that referenced
this pull request
Nov 12, 2025
) As [discussed](https://github.com/apache/kafka/pull/18415/files#r2495342682), the `--fetch-size` parameter description in `ConsumerPerformance` is misleading. It actually sets `max.partition.fetch.bytes` (per-partition limit), not the total fetch size per request. Reviewers: Ken Huang <s7133700@gmail.com>, PoAn Yang <payang@apache.org>, Yung <yungyung7654321@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
shashankhs11
pushed a commit
to shashankhs11/kafka
that referenced
this pull request
Nov 14, 2025
) As [discussed](https://github.com/apache/kafka/pull/18415/files#r2495342682), the `--fetch-size` parameter description in `ConsumerPerformance` is misleading. It actually sets `max.partition.fetch.bytes` (per-partition limit), not the total fetch size per request. Reviewers: Ken Huang <s7133700@gmail.com>, PoAn Yang <payang@apache.org>, Yung <yungyung7654321@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
discussed,
the
--fetch-sizeparameter description inConsumerPerformanceismisleading. It actually sets
max.partition.fetch.bytes(per-partitionlimit), not the total fetch size per request.
Reviewers: Ken Huang s7133700@gmail.com, PoAn Yang
payang@apache.org, Yung yungyung7654321@gmail.com, Chia-Ping Tsai
chia7712@gmail.com