Skip to content

Conversation

@kaka11chen
Copy link
Contributor

@kaka11chen kaka11chen commented Oct 30, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

In ParquetReader::set_fill_columns, the init_row_groups() method is called. If all row groups are filtered out, this situation will lead to returning EOF. This EOF condition may cause other files within the same thread to stop reading.

Check List (For Author)

  • Test
    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
Set pipeline parallelism and I/O parallelism to 1.
be.conf: 
doris_max_remote_scanner_thread_pool_thread_num=1
doris_scanner_thread_pool_thread_num=1
doris_scanner_min_thread_pool_thread_num=1

session var:
set parallel_pipeline_task_num =1;

Test:
in test_hive_write_partitions.groovy.
SELECT * FROM all_partition_types1_parquet_snappy_src where id = 3;
- [ ] No need to test or manual test. Explain why:
    - [ ] This is a refactor/code format and no logic has been changed.
    - [ ] Previous test can cover this change.
    - [ ] No code files have been changed.
    - [ ] Other reason <!-- Add your reason?  -->
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@kaka11chen
Copy link
Contributor Author

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 30, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

ClickBench: Total hot run time: 28.41 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ee4d4c9b480ad77ac28624c3db0d3509b863e7d9, data reload: false

query1	0.06	0.05	0.05
query2	0.10	0.06	0.06
query3	0.26	0.09	0.09
query4	1.60	0.12	0.12
query5	0.28	0.27	0.26
query6	1.19	0.66	0.66
query7	0.03	0.03	0.03
query8	0.06	0.04	0.04
query9	0.64	0.54	0.53
query10	0.59	0.59	0.58
query11	0.18	0.12	0.12
query12	0.17	0.13	0.16
query13	0.63	0.61	0.61
query14	1.02	1.03	1.04
query15	0.89	0.87	0.92
query16	0.41	0.41	0.43
query17	1.10	1.05	1.04
query18	0.23	0.22	0.22
query19	1.96	1.94	1.86
query20	0.02	0.02	0.02
query21	15.42	0.21	0.16
query22	5.05	0.08	0.06
query23	15.63	0.32	0.12
query24	2.59	0.70	0.96
query25	0.09	0.08	0.06
query26	0.16	0.16	0.17
query27	0.06	0.06	0.06
query28	4.86	1.18	0.94
query29	12.58	4.01	3.30
query30	0.28	0.13	0.12
query31	2.83	0.60	0.39
query32	3.25	0.55	0.48
query33	3.12	3.02	3.09
query34	15.80	5.25	4.59
query35	4.61	4.61	4.66
query36	0.72	0.56	0.53
query37	0.11	0.07	0.08
query38	0.07	0.05	0.04
query39	0.04	0.03	0.03
query40	0.18	0.14	0.15
query41	0.09	0.04	0.03
query42	0.05	0.04	0.03
query43	0.05	0.04	0.05
Total cold run time: 99.06 s
Total hot run time: 28.41 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 42.86% (3/7) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.71% (18041/34224)
Line Coverage 37.96% (163722/431250)
Region Coverage 32.33% (124834/386097)
Branch Coverage 33.71% (54586/161952)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 42.86% (3/7) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.44% (24025/33628)
Line Coverage 57.87% (249893/431793)
Region Coverage 52.97% (207386/391501)
Branch Coverage 54.68% (89125/163001)

@morningman morningman merged commit 1e77d34 into apache:master Oct 31, 2025
29 of 34 checks passed
yiguolei pushed a commit that referenced this pull request Nov 3, 2025
…tered. #57490 (#57589)

Cherry-picked from #57490

Co-authored-by: Qi Chen <chenqi@selectdb.com>
kaka11chen added a commit to kaka11chen/doris that referenced this pull request Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.x dev/3.1.x-conflict dev/4.0.1-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants