Skip to content

Conversation

@github-actions
Copy link
Contributor

Cherry-picked from #57365

### Summary
- Build `glueEndpoint` automatically when only `glueRegion` is provided.
- Extract `glueRegion` from `glueEndpoint` when only endpoint is given.
- Reject unsupported endpoint formats (e.g. `.amazonaws.com.cn`).
- Add clear exception messages for invalid or missing configuration.

### Example
| Input | Output / Exception |
|--------|--------------------|
| `glue.region=us-east-1` |
`glue.endpoint=https://glue.us-east-1.amazonaws.com` |
| `glue.endpoint=https://glue.us-east-1.amazonaws.com` |
`glue.region=us-east-1` |
| `glue.endpoint=https://glue.us-east-1.amazonaws.com.cn` | `Invalid AWS
Glue endpoint format` |
| `glue.endpoint=https://glue.us-east-1.amazonaws.com.cn`
`glue.region=us-east-1` |
`glue.endpoint=https://glue.us-east-1.amazonaws.com.cn`
`glue.region=us-east-1` |
@github-actions github-actions bot requested a review from yiguolei as a code owner October 30, 2025 02:48
@Thearas
Copy link
Contributor

Thearas commented Oct 30, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Oct 30, 2025
@Thearas
Copy link
Contributor

Thearas commented Oct 30, 2025

run buildall

@doris-robot
Copy link

ClickBench: Total hot run time: 31.17 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a8bebb37a164a09357fe61d5bda94c0588b24193, data reload: true

query1	0.04	0.04	0.03
query2	0.13	0.04	0.04
query3	0.25	0.07	0.08
query4	1.63	0.12	0.12
query5	0.27	0.25	0.27
query6	1.20	0.66	0.66
query7	0.03	0.03	0.02
query8	0.07	0.05	0.04
query9	0.64	0.54	0.54
query10	0.60	0.59	0.59
query11	0.18	0.11	0.11
query12	0.15	0.12	0.12
query13	0.65	0.61	0.61
query14	0.81	0.85	0.85
query15	0.90	0.89	0.89
query16	0.41	0.40	0.40
query17	1.05	1.11	1.11
query18	0.19	0.19	0.19
query19	2.03	1.88	1.90
query20	0.02	0.01	0.02
query21	15.46	1.02	0.64
query22	0.79	1.24	0.75
query23	15.04	1.48	0.67
query24	16.31	0.66	0.33
query25	0.24	0.13	0.10
query26	0.48	0.17	0.15
query27	0.06	0.06	0.04
query28	8.21	1.02	0.95
query29	12.62	4.21	3.55
query30	0.28	0.13	0.12
query31	2.89	0.64	0.40
query32	3.26	0.60	0.49
query33	3.09	3.32	3.44
query34	17.08	5.86	5.05
query35	5.10	5.23	5.13
query36	0.74	0.55	0.55
query37	0.11	0.08	0.08
query38	0.06	0.06	0.04
query39	0.04	0.03	0.04
query40	0.18	0.16	0.15
query41	0.09	0.04	0.04
query42	0.04	0.03	0.03
query43	0.05	0.04	0.03
Total cold run time: 113.47 s
Total hot run time: 31.17 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants