Skip to content

feat: add max pending entries to all logger plugins #12709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Oct 30, 2025
Merged

feat: add max pending entries to all logger plugins #12709

merged 12 commits into from
Oct 30, 2025

Conversation

@Revolyssup
Copy link
Contributor

@Revolyssup Revolyssup commented Oct 28, 2025 •
edited
Loading

Batch processor was given a configuration point to set max pending entries which is currently being used in kafka logger. #12338
This PR extends it to other loggers

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. enhancement New feature or request labels Oct 28, 2025
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Oct 28, 2025
membphis
membphis approved these changes Oct 30, 2025
View reviewed changes
Copy link
Member

@membphis membphis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Revolyssup Revolyssup merged commit 2c041a3 into apache:master Oct 30, 2025
46 of 62 checks passed
@Revolyssup Revolyssup deleted the revolyssup/max-pend branch October 30, 2025 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@membphis membphis membphis approved these changes

@nic-6443 nic-6443 nic-6443 approved these changes

@AlinsRan AlinsRan AlinsRan approved these changes

@bzp2010 bzp2010 Awaiting requested review from bzp2010

@nic-chen nic-chen Awaiting requested review from nic-chen

Assignees

No one assigned

Labels

enhancement New feature or request size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Revolyssup @membphis @nic-6443 @AlinsRan