Skip to content

Conversation

@turboFei
Copy link
Member

@turboFei turboFei commented Oct 31, 2025

Why are the changes needed?

Using scala.binary.version in spark ecosystem dependency artifactId.

Note that: since spark-4, the scala-2.12 is no longer supported.

Brief change log

  • Using scala.binary.version in spark ecosystem dependency artifactId.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added module:mixed-spark Spark module for Mixed Format module:ams-server Ams server module type:build labels Oct 31, 2025
@turboFei turboFei changed the title Using scala.binary.version for dependency artifactId [AMORO-3851][FOLLOWUP] Using scala.binary.version for dependency artifactId Oct 31, 2025
@turboFei turboFei changed the title [AMORO-3851][FOLLOWUP] Using scala.binary.version for dependency artifactId [AMORO-3851][FOLLOWUP] Using scala.binary.version for Spark dependency artifactId Oct 31, 2025
Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zhoujinsong zhoujinsong merged commit d73496e into apache:master Nov 3, 2025
8 checks passed
@turboFei turboFei deleted the scala_binary_version branch November 3, 2025 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:ams-server Ams server module module:mixed-spark Spark module for Mixed Format type:build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants