WIP: [AMQ-9798] Refactored Web Console and removed dependency on Spring-MVC. #1523
+394
−450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattrpav
changed the title
|
Can we also write some tests for the change? Great initiative! |
Yes, if we don't need any major change to the PR I will include some unit tests. At least for the classes I've added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the dependency on Spring MVC and does some clean ups in the Web Console. Apologize for the long PR.
I tested each page using Chrome and did some sanity tests using Firefox. I was unable to test running the console on an OSGI container, but I can test if we think is necessary.