Skip to content

Conversation

@jacobrkerstetter
Copy link
Contributor

Description

  • added ability to find all named selections that a geometric entity belongs to
  • for bodies, faces, edges, beams, design points, components, and vertices

Issue linked

Closes #2326

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@jacobrkerstetter jacobrkerstetter self-assigned this Nov 4, 2025
@jacobrkerstetter jacobrkerstetter requested a review from a team as a code owner November 4, 2025 19:15
@github-actions github-actions bot added the enhancement New features or code improvements label Nov 4, 2025
@jacobrkerstetter jacobrkerstetter marked this pull request as draft November 4, 2025 20:34
@jacobrkerstetter jacobrkerstetter marked this pull request as ready for review November 11, 2025 16:29
@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

❌ Patch coverage is 69.44444% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.66%. Comparing base (b26a2bf) to head (e7eec4f).

Files with missing lines Patch % Lines
src/ansys/geometry/core/designer/vertex.py 42.85% 8 Missing ⚠️
src/ansys/geometry/core/designer/component.py 16.66% 5 Missing ⚠️
src/ansys/geometry/core/designer/design.py 33.33% 2 Missing ⚠️
src/ansys/geometry/core/misc/auxiliary.py 50.00% 2 Missing ⚠️
src/ansys/geometry/core/designer/body.py 92.30% 1 Missing ⚠️
src/ansys/geometry/core/designer/designpoint.py 90.00% 1 Missing ⚠️
src/ansys/geometry/core/designer/edge.py 85.71% 1 Missing ⚠️
src/ansys/geometry/core/designer/face.py 83.33% 1 Missing ⚠️
src/ansys/geometry/core/designer/selection.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2356      +/-   ##
==========================================
- Coverage   95.20%   92.66%   -2.55%     
==========================================
  Files         168      166       -2     
  Lines       11108    11132      +24     
==========================================
- Hits        10575    10315     -260     
- Misses        533      817     +284     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot added the testing Anything related to tests label Nov 11, 2025
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments! Looks pretty good though :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements testing Anything related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add GetNamedSelections to geometric entities

4 participants