-
Notifications
You must be signed in to change notification settings - Fork 76
[AAH-2539] about modals (hub, awx, eda upstream) #2603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ShaiahWren
wants to merge
27
commits into
main
Choose a base branch
from
new-about-modals
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiyiprh
previously approved these changes
Jun 26, 2024
4067d36 to
08f8227
Compare
7397c14 to
06b0d12
Compare
06b0d12 to
2bbd9af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue: https://issues.redhat.com/browse/AAH-2539
Please review this new pr for service about modals, opened in favor of #1850, which is now closed.
After careful review with the UX team on 6/26/24, note the following:
<DescriptionList>patternfly component with the 'horizontal' prop. The columns collapse on smaller/mobile screens.EDA Server version info is not available and is being addressed in AAH-22119Now using/api/eda/v1/configendpoint for EDA version.AWX:

Ansible Galaxy

EDA Server:
