-str Remove deprecated methods in GraphStage since 2.6.0 #32059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
He-Pin
force-pushed
the
removeOnDownstreamFinish
branch
from
5aef59c to
06b8733
Compare
He-Pin
changed the title
onDownstreamFinish() in GraphStage.
He-Pin
force-pushed
the
removeOnDownstreamFinish
branch
from
06b8733 to
fc45c64
Compare
He-Pin
force-pushed
the
removeOnDownstreamFinish
branch
from
fc45c64 to
ff27e09
Compare
patriknw
reviewed
Aug 28, 2023
| @throws(classOf[Exception]) | ||
| @deprecatedOverriding("Override `def onDownstreamFinish(cause: Throwable)`, instead.", since = "2.6.0") // warns when overriding | ||
| @deprecated("Call onDownstreamFinish with a cancellation cause.", since = "2.6.0") // warns when calling | ||
| def onDownstreamFinish(): Unit = { |
There was a problem hiding this comment.
Wonder if this has been fully migrated everywhere in Akka libraries? We might want to keep this for some longer.
There was a problem hiding this comment.
Only stream contrib among the repo mains as far as I can see, but still might be best to keep it around for some more time.
|
TimerScheduler and Scheduler have the same thing here, you may want to remove it too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove deprecated methods in GraphStage since 2.6.0