Line up boot time icon pattern (even/odd row number) #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The disk icon and mac icon shown during early boot are blitted as solid icons, with the 50% tone background baked in. The original display height was not a multiple of 4, so this ended up at an odd screem line. e.g., 145. When a multiple of 4 screen height was used instead, it ended up at an even screen line, e.g., 214. This makes the pattern clash with the surrounding background. Ensuring the row number used for "mid screen" is odd fixes this. Since the original width was a multiple of 4, horizontally centered items were fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The disk icon and mac icon shown during early boot are blitted as solid icons, with the 50% tone background baked in.
The original display height was not a multiple of 4, so this ended up at an odd screem line. e.g., 145.
When a multiple of 4 screen height was used instead, it ended up at an even screen line, e.g., 214. This makes the pattern clash with the surrounding background.
Ensuring the row number used for "mid screen" is odd fixes this.
Since the original width was a multiple of 4, horizontally centered items were fine.