[help_editor] Translate help editor module #10009
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Language: Javascript
SKADE2303
added
Event: GSOC
driusan
reviewed
Sep 12, 2025
| id="save-help" | ||
| name="fire_away" | ||
| value="Save" | ||
| value={t('Save', {ns: 'help_editor'})} |
Collaborator
There was a problem hiding this comment.
Not sure if this exists in the loris namespace but it probably should. I'd be surprised if this was the only place we said "Save"
Contributor
There was a problem hiding this comment.
It's not there.. but agree, this should be in loris.po
driusan
reviewed
Sep 12, 2025
| // XXX: Replace this with a UI component for 500 errors. | ||
| if (this.state.error) { | ||
| return <h3>An error occured while loading the page.</h3>; | ||
| return <h3>{t('An error occured while loading the page.', |
Contributor
There was a problem hiding this comment.
yes,
please point to the correct namespace @SKADE2303
racostas
added
the
State: Needs work
SKADE2303
removed
the
State: Needs work
racostas
requested changes
Oct 20, 2025
Contributor
racostas
left a comment
racostas
left a comment
There was a problem hiding this comment.
Please solve conflicts, also some translations are still not showing for me.
Comment on lines
74
to
79
| confirmButtonText: 'Close', | ||
| confirmButtonText: t('Close', {ns: 'help_editor'}), |
Contributor
There was a problem hiding this comment.
I think "Close" is general enough to go loris namespace.
racostas
added
the
State: Needs work
SKADE2303
force-pushed
the
TranslateHelpEditor
branch
from
ebec2ae to
f8d21df
Compare
SKADE2303
removed
the
State: Needs work
Contributor
|
@SKADE2303, please fix tests. |
racostas
added
the
State: Needs work
SKADE2303
added
State: Blocking
racostas
requested changes
Nov 3, 2025
Contributor
racostas
left a comment
racostas
left a comment
There was a problem hiding this comment.
Translations missing yet:
Comment on lines
216
to
221
| msgid "Sent To DCC" | ||
| msgstr "" | ||
|
|
Contributor
There was a problem hiding this comment.
Please remember we need both "Send and Sent to DDC" in the loris.pot they are both used in instruments modules. I think to remember this comment was already made before during a previous module revision. Thanks.
racostas
added
the
State: Needs work
Contributor
added 4 commits
November 4, 2025 07:21
SKADE2303
force-pushed
the
TranslateHelpEditor
branch
from
bb589fc to
3cf05c0
Compare
SKADE2303
force-pushed
the
TranslateHelpEditor
branch
from
3cf05c0 to
8d96185
Compare
SKADE2303
force-pushed
the
TranslateHelpEditor
branch
from
a1eb926 to
14575a7
Compare
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is responsible for translating the module help_editor to different languages. Currently only 'Hindi' language is supported but other languages can be added as required.
Testing instructions (if applicable)