Skip to content

Fix #175: Replace unsafe assert statements with explicit exceptions #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix #175: Replace unsafe assert statements with explicit exceptions #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/container_inspector/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@ def container_inspector_squash(image_path, extract_directory):

def _container_inspector_squash(image_path, extract_directory):
images = get_images_from_dir_or_tarball(image_path)
assert len(images) == 1, 'Can only squash one image at a time'
if len(images) != 1:
raise ValueError('Can only squash one image at a time')
img = images[0]
target_loc = os.path.abspath(os.path.expanduser(extract_directory))
rootfs.rebuild_rootfs(img, target_loc)
Expand All @@ -61,7 +62,8 @@ def container_inspector_dockerfile(directory, json=False, csv=False):


def _container_inspector_dockerfile(directory, json=False, csv=False):
assert json or csv, 'At least one of --json or --csv is required.'
if not (json or csv):
raise ValueError('At least one of --json or --csv is required.')
dir_loc = os.path.abspath(os.path.expanduser(directory))

dockerfiles = dockerfile.collect_dockerfiles(location=dir_loc)
Expand Down