Skip to content

Conversation

@anmode
Copy link
Contributor

@anmode anmode commented Feb 18, 2023

Reference - olefirenko/vue-google-autocomplete#73 (comment)

Before:

Screen.Recording.2023-02-18.at.9.14.21.AM.-.Compressed.with.FlexClip.mp4

After:

Screen.Recording.2023-02-18.at.9.16.05.AM.-.Compressed.with.FlexClip.mp4

@tuukka
Copy link
Contributor

tuukka commented Mar 22, 2023

Please see the feedback I've given to your previous pull requests, they apply here as well.

Also, what's the purpose of such empty lifecycle functions as opposed to removing them? And while you're fixing these, why not fix the same issue in all the other components as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants