-
Notifications
You must be signed in to change notification settings - Fork 2
Add downloading multiple data options function #519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add downloading multiple data options function #519
Conversation
bencap
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice and works well for me, thanks! Not explicitly necessary, but this might be a good spot for a small pop out dialog that has these check boxes instead of putting them on the score set page directly.
@bencap Yup, I also think a pop out dialog is better and change it to a pop out dialog. |
| <Button class="p-button-outlined p-button-sm" @click="showOptions()"> Custom Data </Button> | ||
| <Dialog | ||
| v-model:visible="optionsVisible" | ||
| :breakpoints="{'1199px': '75vw', '575px': '90vw'}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a :base-z-index="901" to the dialog should make it display without the score set legend appearing highlighted. Looks great otherwise!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ben! I don't have this problem, but maybe because different laptops or browsers. I added it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh weird, yeah maybe it is dependent on browser.
bencap
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
…nt/estelle/446/namespacedVariantCSVExport
…nt/estelle/446/namespacedVariantCSVExport
The UI part of VariantEffect/mavedb-api#446.