Skip to content

Conversation

@EstelleDa
Copy link
Member

Copy link
Collaborator

@bencap bencap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice and works well for me, thanks! Not explicitly necessary, but this might be a good spot for a small pop out dialog that has these check boxes instead of putting them on the score set page directly.

@bencap bencap changed the base branch from release-2025.4.5 to release-2025.4.6 October 24, 2025 17:05
@EstelleDa
Copy link
Member Author

Looks nice and works well for me, thanks! Not explicitly necessary, but this might be a good spot for a small pop out dialog that has these check boxes instead of putting them on the score set page directly.

@bencap Yup, I also think a pop out dialog is better and change it to a pop out dialog.

<Button class="p-button-outlined p-button-sm" @click="showOptions()"> Custom Data </Button>
<Dialog
v-model:visible="optionsVisible"
:breakpoints="{'1199px': '75vw', '575px': '90vw'}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a :base-z-index="901" to the dialog should make it display without the score set legend appearing highlighted. Looks great otherwise!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ben! I don't have this problem, but maybe because different laptops or browsers. I added it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh weird, yeah maybe it is dependent on browser.

Copy link
Collaborator

@bencap bencap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@bencap bencap changed the base branch from release-2025.4.6 to release-2025.5.0 November 6, 2025 22:58
@EstelleDa EstelleDa merged commit deb258d into release-2025.5.0 Nov 11, 2025
@EstelleDa EstelleDa deleted the enhancement/estelle/446/namespacedVariantCSVExport branch November 11, 2025 07:20
@bencap bencap linked an issue Nov 13, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Namespaced variant CSV export

3 participants