Fix tf_point_weapon_mimic not using Fire Sound #1631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simply adds an EmitSound to Fire that uses m_pzsFireSound (which is defined, but not used anywhere) before the switch case for picking the right weapon type.
ficool2
reviewed
Nov 7, 2025
| { | ||
| Assert( m_nWeaponType >= 0 && m_nWeaponType < WEAPON_TYPES ); | ||
|
|
||
| PrecacheScriptSound( m_pzsFireSound ); |
Contributor
There was a problem hiding this comment.
Should be precaching in CTFPointWeaponMimic::Precache
Author
There was a problem hiding this comment.
I don't see this function for the entity, am I supposed to add this and use PrecacheScriptSound there?
Author
There was a problem hiding this comment.
changed to your suggestion, was it done correctly?
also move model precache into this new function for consistency
ficool2
reviewed
Nov 7, 2025
| void CTFPointWeaponMimic::Spawn() | ||
| { | ||
| BaseClass::Spawn(); | ||
| Precache(); |
Contributor
There was a problem hiding this comment.
Precache is called by the game, you don't call it yourself
Author
There was a problem hiding this comment.
It doesn't seem to precache without the explicit call in Spawn, as removing the call will now produce "<sound> not precached" and not play.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simply adds an EmitSound to Fire that uses
m_pzsFireSound(which is defined, but not used anywhere) before the switch case for picking the right weapon type.I have read and agree to the terms for making this pull request.