[TF2] Fix Loose Cannon MvM damage upgrade not scaling entirely #1618
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Loose Cannon's overall damage is in 2 parts. Only the 2nd part was being scaled by mult_dmg. This fix allows the 1st part to be scaled too-- due to the Ullapool Caber now holding the same change with both damage instances being scaled by mult_dmg.
Marxvee
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Loose Cannon's overall damage is in 2 parts. Currently, only the second part (explosion) is being scaled by mult_dmg. This fix allows the first part (impact) to be scaled too-- inspired from the Ullapool Caber receiving a similar change with both damage instances (impact and explosion) now being scaled by mult_dmg.
Old base damage calculations (assuming close range):
No damage upgrades:
50 impact
60 explosion (81 double donk minicrit)
110 total, 131 if double donk
+100% damage bonus in MvM:
50 impact
120 explosion (162 double donk minicrit)
170 total, 212 if double donk (not truly a +100% damage bonus)
New base damage calculations:
No damage upgrades:
50 impact
60 explosion (81 double donk minicrit)
110 total, 131 if double donk
+100% damage bonus in MvM:
100 impact
120 explosion (162 double donk minicrit)
220 total, 262 if double donk (double the amount of 131, now the damage upgrade print label is accurate)