Skip to content

Conversation

@kwasniew
Copy link
Contributor

@kwasniew kwasniew commented May 16, 2025

About the changes

Changes:

  • Migration to have a join table between features and projects
  • Create feature writes to old project and new join table
  • Search query by project uses the join table (should be behind a flag in the final version)
  • Single feature query uses new join table - getProjectId to plural
  • Parent dependency same project check modified
  • Client api updated to include shared flags
  • (NO WORK NEEDED) Project segments - work out of the box
  • (NO WORK NEEDED) Each project has own permissions/CR settings
  • TODO and not covered here: Update strategy in a flag form another project

No UI for flag sharing. Direct SQL used instead: insert into feature_project (feature_name, project_id) values ('flag_name', 'project_to_share_with');

You can run the code locally (CI build is failing because I optimized for testing it manually in the UI)

Important files

Discussion points

@vercel
Copy link

vercel bot commented May 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) May 16, 2025 7:34am

@github-actions
Copy link
Contributor

@kwasniew, core features have been modified in this pull request. Please review carefully!

@github-actions
Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@ivarconr ivarconr moved this from New to In Progress in Issues and PRs May 22, 2025
@kwasniew kwasniew marked this pull request as draft October 6, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants