Fix subscription discoverability for no-subscribers #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
UncleGoogle
commented
Oct 3, 2021
UncleGoogle
commented
- for those who has never subscribed - allow to select manually latest choice subscription (just to reveal games)
- handle unknown subscription status - just in case it will fail later on
- handle expired subscriptions - set proper ownership and discoverability
also - do not use changed marketing data
|
This pull request introduces 1 alert when merging 2b75f10 into 16726d5 - view on LGTM.com new alerts:
|
UncleGoogle
force-pushed
the
master
branch
2 times, most recently
from
758e21a to
1535af1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.