Fixed re-rendering issues with React StrictMode #986
Conversation
…g back enforced language client disposal - Renamed LanguageClientsManager to LanguageClientManager - Update dependencies - Fix lint issues
|
@CGNonofr I will release a next versions soon, so people can test it. If that looks good, the PR will be ready for review. |
- Updated dependencies and changelogs
kaisalmen
changed the title
|
@CGNonofr this is ready to review now. I added additional react component unit tests We now have 20 unit tests for the react component and 111 total. The new test cases ensure the fixes for #975 and #988 are valid and that the fixes are not invalidated in the future. vite browser tests rule! 🙂 @martin-fleck-at do see any further problems on your end? |
CGNonofr
left a comment
CGNonofr
left a comment
There was a problem hiding this comment.
Sorry, forgot to submit my review!
|
@CGNonofr and @martin-fleck-at I converted it back to a Draft. I want to fix the problems you mentioned, first. This is getting lengthy, in kn ow, but theses are all valid points. The first issue @CGNonofr brought up is resolved, though. |
…options can be updated without restarting the editor
…uageClientWrapper and LanguageClientManager
|
@CGNonofr rework is complete. Ready for review, Part 2. New next releases will be there soon. |
|
These new next releases are in-line with the last commit: |
|
115 tests! 🎉 |
Fixes #975
Fixes #988