Add SLAy auto-merge preset #4190
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejoe91
reviewed
Oct 31, 2025
alejoe91
reviewed
Oct 31, 2025
alejoe91
reviewed
Oct 31, 2025
alejoe91
reviewed
Oct 31, 2025
alejoe91
reviewed
Oct 31, 2025
alejoe91
reviewed
Oct 31, 2025
alejoe91
reviewed
Oct 31, 2025
alejoe91
reviewed
Oct 31, 2025
alejoe91
reviewed
Oct 31, 2025
alejoe91
reviewed
Oct 31, 2025
| return sig | ||
|
|
||
|
|
||
| def _sliding_RP_viol_pair( |
There was a problem hiding this comment.
Could we try to unify with this code @chrishalcrow ?
https://github.com/SpikeInterface/spikeinterface/blob/main/src/spikeinterface/qualitymetrics/misc_metrics.py#L1493-L1511
alejoe91
reviewed
Oct 31, 2025
Comment on lines
1746
to
1750
| bin_rate_max = np.max(smoothed_acg) | ||
| max_conts_max = np.array(bTest) / bin_size_ms * 1000 * (bin_rate_max * acceptThresh) | ||
| # compute confidence of less than acceptThresh contamination at each refractory period | ||
| confs = 1 - poisson.cdf(sum_res, max_conts_max) | ||
| rp_viol = 1 - confs.max() |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SLAy as a method for
compute_merge_unit_groupshttps://www.biorxiv.org/content/10.1101/2025.06.20.660590v1SLAy combines a template similarity measure, a cross-correlation significance measure and a sliding refractory period violation measure to make a merge decision. You need an analyzer with templates, correlograms and template_similarity. If you do, you can try it using:
or, for more control, e.g.
This is an approximate implementation. Some details
_sliding_RP_violand_compute_xcorrfunctions from https://github.com/saikoukunt/SLAy . I think the sliding RP computation is fairly different between our implementation in quality_metrics. Will take a closer look...To do:
With help and permission from @saikoukunt