-
Notifications
You must be signed in to change notification settings - Fork 226
Fix silence period and job_kwargs #4071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yger
wants to merge
21
commits into
SpikeInterface:main
Choose a base branch
from
yger:fix_silence_period
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
04ca583
WIP
yger 983bf3d
Fix
yger f841e37
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] e03cd61
Fixes also the noise levels in detect_peaks
yger b90d533
Merge branch 'fix_silence_period' of github.com:yger/spikeinterface i…
yger 75c3981
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 4a228dc
Merge branch 'main' into fix_silence_period
yger 19380f7
WIP
yger 94300dd
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] b609700
Keep local computations of noise_levels if no pipeline
yger 1954fb5
Merge branch 'fix_silence_period' of github.com:yger/spikeinterface i…
yger 05f10d1
Oups
yger e6b6686
Remove job_kwargs from signature
yger c7934dd
Docs
yger d818bfb
More consistent
yger e0a34a7
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 5cc636a
Merge branch 'main' of https://github.com/SpikeInterface/spikeinterfa…
yger 36a675f
Merge branch 'main' of github.com:spikeinterface/spikeinterface into …
yger 9675469
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 274e370
Updates
yger 73bef41
WIP
yger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't play with the
_kwargs. Will this update lead to incompatible keys between spikeinterface versions?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually this is a good question, and we should discuss this PR with @samuelgarcia . Indeed, moving the computation of noise levels into the detect_peaks() and not in the node themselves is the only option to control finely the job_kwargs. Not sure we need to save the noise_level_kwargs because the noise_levels are cached per recording I think, and not recomputed during parallel processing. I'll double check with @samuelgarcia