-
-
Notifications
You must be signed in to change notification settings - Fork 414
PropertyBaseEffect #8256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev/feature
Are you sure you want to change the base?
PropertyBaseEffect #8256
Conversation
…to dev/feature
…to dev/feature
…to dev/feature
…to dev/feature
…to dev/feature
|
This will remain in draft until properties are officially fully released and ready to go. |
src/main/java/org/skriptlang/skript/common/types/ScriptClassInfo.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/common/types/ScriptClassInfo.java
Outdated
Show resolved
Hide resolved
| Skript.registerEffect(EffWorldLoad.class, | ||
| "load [the] world[s] %strings% [with environment %-environment%]", | ||
| "unload [[the] world[s]] %worlds% [:without saving]" | ||
| "unload [[the] world[s]] %worlds% without saving" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note that technically this removes the patterns unload [the] world[s] %worlds% which is breaking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would you advise to be done?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
either
a) add it back
b) note it as a breaking change
i'm not partial to either but a is probably better experience for users
Problem
The current property system does not yet have support for common effect syntaxes and no common property handler used for effects.
Solution
Adds PropertyBaseEffect, class for using common effects with only 1 input in the syntax.
Adds EffectHandler, common handler used in PropertyBaseEffect
Adds effects and properties for: load, unload, reload, enable, and disable.
ScriptClassInfo includes all of these properties
Moves classinfo for World into it's own class, WorldClassInfo, with an unload property.
Refactors EffScriptFile to enable/load/reload a script with errors to be printed, removes some patterns that are now in ExprScript, and moved into org.
Refactors EffWorldLoad with the only unload option to be without saving
Testing Completed
quickTest
Supporting Information
N/A
Note
PR currently fails due to pattern conflicts because of property syntaxes and their original classes.
Completes: none
Related: none