Skip to content

Conversation

@Absolutionism
Copy link
Contributor

Problem

The current property system does not yet have support for common effect syntaxes and no common property handler used for effects.

Solution

Adds PropertyBaseEffect, class for using common effects with only 1 input in the syntax.
Adds EffectHandler, common handler used in PropertyBaseEffect
Adds effects and properties for: load, unload, reload, enable, and disable.
ScriptClassInfo includes all of these properties
Moves classinfo for World into it's own class, WorldClassInfo, with an unload property.

Refactors EffScriptFile to enable/load/reload a script with errors to be printed, removes some patterns that are now in ExprScript, and moved into org.
Refactors EffWorldLoad with the only unload option to be without saving

Testing Completed

quickTest

Supporting Information

N/A

Note
PR currently fails due to pattern conflicts because of property syntaxes and their original classes.


Completes: none
Related: none

@Absolutionism
Copy link
Contributor Author

This will remain in draft until properties are officially fully released and ready to go.

@Absolutionism Absolutionism moved this to In Review in 2.14 Releases Nov 2, 2025
@Absolutionism Absolutionism added 2.14 Targeting a 2.14.X version release. feature Pull request adding a new feature. labels Nov 2, 2025
Skript.registerEffect(EffWorldLoad.class,
"load [the] world[s] %strings% [with environment %-environment%]",
"unload [[the] world[s]] %worlds% [:without saving]"
"unload [[the] world[s]] %worlds% without saving"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that technically this removes the patterns unload [the] world[s] %worlds% which is breaking.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would you advise to be done?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

either
a) add it back
b) note it as a breaking change
i'm not partial to either but a is probably better experience for users

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.14 Targeting a 2.14.X version release. feature Pull request adding a new feature.

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

2 participants