Fix SRF "gallery format" overlay and redirect #977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MediaWiki's evolution of its gallery HTML structure forces SRF to adapt. MediaWiki has adopted a "mw-file-description" HTML class as more semantic and specific for file description links in gallery displays. It replaces the former, generic, "image" class applied to the same elements. So, Semantic Result Formats - Gallery output needs to adapt specifically in its "overlay" and "redirect" options because they relied upon the old HTML output of MediaWiki. - modifies the JavaScript files for overlay and redirect - Adds QUnit tests for overlay and redirect with assertions about the HTML - Fixup to the 'fancybox' jQuery module (without upgrading) If running this in a containerized / development environment, you can test only gallery-related functionality "cd /var/www/html/extensions/SemanticResultFormats && composer phpunit -- --filter Gallery" Fixes Issue SemanticMediaWiki#940 with explanation by @ADB-Linux
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #977 +/- ##
=========================================
Coverage 46.24% 46.24%
Complexity 2361 2361
=========================================
Files 80 80
Lines 8957 8957
=========================================
Hits 4142 4142
Misses 4815 4815 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MediaWiki's evolution of its gallery HTML structure forces SRF to adapt.
MediaWiki has adopted a "mw-file-description" HTML class as more semantic and specific for file description links in gallery displays. It replaces the former, generic, "image" class applied to the same elements.
So, Semantic Result Formats - Gallery output needs to adapt specifically in its "overlay" and "redirect" options because they relied upon the old HTML output of MediaWiki.
If running this in a containerized / development environment, you can test only gallery-related functionality
"cd /var/www/html/extensions/SemanticResultFormats && composer phpunit -- --filter Gallery"
Fixes Issue #940 with explanation by @ADB-Linux