base64ct, base32ct: proptests for decoder equivalence with base32/64 #2085
+51
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
reviewed
Nov 6, 2025
For the base64 case, this MR adds proptests to ensure that base64 and base64ct accept the same inputs when decoding, and produce the same outputs when decoding them. For the base32 case, that property isn't actually true. Instead, the proptest makes sure that whenever base32 and base32ct both accept an input when decoding, they produce the same output.
nmathewson
force-pushed
the
proptest_decode_equivalence
branch
from
dd0bea8 to
4698278
Compare
tarcieri
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the base64 case, this MR adds proptests to ensure that base64 and base64ct accept the same inputs when decoding, and produce the same outputs when decoding them.
For the base32 case, that property isn't actually true. Instead, the proptest makes sure that whenever base32 and base32ct both accept an input when decoding, they produce the same output.
Based on discussion at #2084.