Skip to content

Conversation

@teclabat
Copy link

@teclabat teclabat commented Nov 5, 2025

replace parse_args
fix a few tests

@teclabat
Copy link
Author

teclabat commented Nov 5, 2025

When I test, I get the following:

Tests began at Wed Nov 05 23:57:50 +0100 2025
_parser.test
amap.test
array.test
boolean.test
decode.test
exists.test
extract.test
foreach.test
get.test
jsontestsuite.test
keys.test
length.test
lmap.test
memory.test
misc.test
new.test
normalize.test
number.test
object.test
omap.test
parse.test
pretty.test
can't find package parse_args
set.test
can't find package parse_args
string.test
template.test
template_string.test
type.test
unset.test
can't find package parse_args
valid.test

Environment: Windows, msys2, mingw64

Looks to me as the TEA Makefile only loads one package, the rl_json, but is missing the parse_args:

PACKAGE_LOAD = "package ifneeded $(PACKAGE_NAME) $(PACKAGE_VERSION) [list apply {dir {load `cygpath -m $(PKG_LIB_FILE)` $(PACKAGE_NAME)}} `cygpath -m $(srcdir)`]"
PACKAGE_LOAD_EMBED = package\ ifneeded\ $(PACKAGE_NAME)\ $(PACKAGE_VERSION)\ [list\ apply\ {dir\ {load\ `cygpath -m $(PKG_LIB_FILE)`\ $(PACKAGE_NAME)}}\ `cygpath -m $(srcdir)`]

(but I could be terribly wrong on how all this should work together)

@teclabat
Copy link
Author

teclabat commented Nov 5, 2025

When I run the tests manually all tests pass:

 ../../release/bin/tclsh tests/all.tcl
Tests running in interp:       D:/CM.work/tcltk86/release/bin/tclsh.exe
Tests running with pwd:        D:/CM.work/tcltk86/rcompile/rljson
Tests running in working dir:  D:/CM.work/tcltk86/rcompile/rljson/tests
Only running tests that match:        *
Skipping test files that match:       l.*.test
Only sourcing test files that match:  *.test
Tests began at Thu Nov 06 00:29:02 CET 2025
_parser.test
amap.test
array.test
boolean.test
decode.test
exists.test
extract.test
foreach.test
get.test
jsontestsuite.test
keys.test
length.test
lmap.test
memory.test
misc.test
new.test
normalize.test
number.test
object.test
omap.test
parse.test
pretty.test
set.test
string.test
template.test
template_string.test
type.test
unset.test
valid.test

Tests ended at Thu Nov 06 00:29:03 CET 2025
all.tcl:        Total   2504    Passed  2503    Skipped 1       Failed  0
Sourced 0 Test Files.
Number of tests skipped for each constraint:
        1       deliberateLeak

Indeed the Makefile is using the tclsh from inside the compile directory (of the previous TCL compile), but not the tclsh where it is installed and all the packages are installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant