Skip to content

Conversation

@meiravgri
Copy link
Collaborator

@meiravgri meiravgri commented Nov 11, 2025

Fix 1:

Consolidation during deleteVector() operations blocks the main thread significantly.
Benchmarks show ~20 seconds to delete 500 vectors from a 1M vector index.
This PR removes automatic consolidation, leaving cleanup to the GC process.

Fix 2:

Align indexSize and indexLabelCount with HNSW behaviour:
IndexSize = indexLabelCount + num_marked_deleted
indexLabelCount represents only valid vectors.
Note: Unlike hnsw, svs doesn't perform in-place deletion, so this logic also applies to svs in a non-tiered index context.

@meiravgri meiravgri changed the title remove consolidate from delete [MOD-12346] Remove main-thread graph repair from SVS delete operations Nov 11, 2025
@meiravgri meiravgri requested a review from alonre24 November 11, 2025 12:52
@meiravgri meiravgri enabled auto-merge November 11, 2025 12:56
@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.66%. Comparing base (1a15b59) to head (3ae28cd).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #831      +/-   ##
==========================================
+ Coverage   96.63%   96.66%   +0.02%     
==========================================
  Files         126      126              
  Lines        7379     7374       -5     
==========================================
- Hits         7131     7128       -3     
+ Misses        248      246       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

indexLabelCount -> only valid vectors
@meiravgri meiravgri requested a review from alonre24 November 11, 2025 18:00
alonre24
alonre24 previously approved these changes Nov 12, 2025
Copy link
Collaborator

@alonre24 alonre24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@meiravgri meiravgri added this pull request to the merge queue Nov 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants