Skip to content

[release/2.7][ROCm][inductor] Inductor heuristic upstream backports #2807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 20 commits into
base: release/2.7
Choose a base branch
from
Draft

[release/2.7][ROCm][inductor] Inductor heuristic upstream backports #2807

wants to merge 20 commits into from
+362 −55

Conversation

@naromero77amd
Copy link

@naromero77amd naromero77amd commented Nov 15, 2025

These are backports based on these four upstream PRs:

pytorch#163908 (persistent reduction autotune)
pytorch#161280 (reduction)
pytorch#162053 (foreach)
pytorch#163197 (pointwise)

Also included are some additional customer-specific configs which were not upstreamed:

Similar to this backport PR for ROCm fork release/2.9:
#2723

jataylo and others added 19 commits November 14, 2025 22:52
@jataylo @naromero77amd
Naive foreach autotune support
24717c3 
(cherry picked from commit 5d4455f)
(cherry picked from commit d3d77f5)
@jataylo @naromero77amd
Update triton_heuristics.py
ec5765e 
(cherry picked from commit 2fc7525)
(cherry picked from commit 528cf02)
@jataylo @naromero77amd
Update triton_heuristics.py
a49093e 
(cherry picked from commit d5c71f0)
(cherry picked from commit 11e1dfc)
@jataylo @naromero77amd
Linting
1363a1c 
(cherry picked from commit 262a33e)
(cherry picked from commit 0cf1c89)
@naromero77amd
Conditionalize xblock values for HIP.
f80f0b8
@naromero77amd
Create tiny_config.
5ed2f82 
(cherry picked from commit 9f19754)
(cherry picked from commit dee2fdf)
@AmdSampsa @naromero77amd
pointwise autotuning returnz (#2636)
c269eb3 
removed the (erroneous?) check that disables autotuning for pointwise
kernels

(cherry picked from commit e3b8e25)
(cherry picked from commit 10af207)
(cherry picked from commit b9e0182)
@AmdSampsa @naromero77amd
a few more configs for 2d grids (#2649)
d13e652 
Added two nice grid configs for the 2d pointwise kernel cases for WRT5
workload.
Confirmed that they were picked up when using max autotune.

(cherry picked from commit f1eac49)
(cherry picked from commit 2e79001)
(cherry picked from commit 04aa3e4)
@naromero77amd
[ROCm][inductor] Additional pointwise tunings (#2642)
a13015c 
This config improves the performance of a 1D pointwise kernel by 20% as
measured on MI350.

(cherry picked from commit a7bac0a)
(cherry picked from commit 0bdb796)
(cherry picked from commit af5f678)
@naromero77amd
pointwise config with MAX_BLOCK.
3d716eb 
(cherry picked from commit 16e8266)
(cherry picked from commit 8bd33f9)
@naromero77amd
Update triton_config method.
7edd183 
(cherry picked from commit dfc1579)
(cherry picked from commit 8f60456)
@naromero77amd
Increase TRITON_MAX_BLOCK X value.
adc6a45 
(cherry picked from commit 666e81b)
(cherry picked from commit f6aaaf8)
@AmdSampsa @naromero77amd
even more configs
b1f1c36 
(cherry picked from commit f97c7a9)
(cherry picked from commit db49466)
(cherry picked from commit 6e9b4ee)
(cherry picked from commit c36d85f)
@jataylo @naromero77amd
More ROCm conditionalisation
26f8133 
(cherry picked from commit 0c52d01)
(cherry picked from commit 83e453f)
@naromero77amd
Lint.
c1f8e99 
(cherry picked from commit dd990a3)
(cherry picked from commit 0de435f)
@naromero77amd
Reduction heursitics improvements for ROCm
0a9dcdd 
(cherry picked from commit 9534cbd)
(cherry picked from commit 189481e)
@naromero77amd
Add PropagateNan argument to minimum and maximum function.
768ab84 
(cherry picked from commit 7eeb1ba)
(cherry picked from commit eea659c)
@AmdSampsa @naromero77amd
New WRT configs for autotuning (#2708)
451c2b4 
Reorganized slightly the adding of hard-coded autotuning configs.
Fixed wrt1 configs.
Added wrt2 & 3 configs.

(cherry picked from commit e3e9a17)
(cherry picked from commit 6534df0)
@naromero77amd
Align TRITON_MAX_BLOCK code with upstream.
7850a9c
@naromero77amd naromero77amd marked this pull request as draft November 15, 2025 01:37
@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Nov 15, 2025 •
edited
Loading

Jenkins build for 7850a9c97813ff2687769efd9a6c4ff5ff749187 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Nov 15, 2025 •
edited
Loading

Jenkins build for dbdb5542c2ae0f09415495c33bfd7d5d0f77bc53 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jataylo jataylo Awaiting requested review from jataylo

@pruthvistony pruthvistony Awaiting requested review from pruthvistony

@jeffdaily jeffdaily Awaiting requested review from jeffdaily

@jithunnair-amd jithunnair-amd Awaiting requested review from jithunnair-amd

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@naromero77amd @jataylo @AmdSampsa