Make copydir work again - fixes issue #90 #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i18n-tribe
force-pushed
the
make_copydir_work_again---fixes_issue-90
branch
from
959f732 to
e9ee191
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the
preserve_timekwarg was added to thefs.copydirmethod in PyFilesystem core, it has not been possible to usefs.copydirwith an S3 backend. See this issue for more details.The same issue probably also affects
fs.move, because this method also uses the samecopyimplementation under the hood. I haven't testedfs.movewith S3FS, but it's likely it is also broken currently, and will be fixed by this PR.This small PR will make S3FS compatible with PyFilesystem core again. It fixes code that has broken since PyFilesystem core introduced the
preserve_timefeature.This PR will enable
fs.copydirandfs.movewithpreserve_timeis set asFalse(the default).This PR does not attempt to implement any new functionality. If
preserve_timeis set asTrue, aNotImplementedErrorwill be raised.If someone needs the
preserve_time=Truefuncationality with S3FS, this could be implemented in a future PR.For now – this PR will unblock users who do not need this new feature.