-
Notifications
You must be signed in to change notification settings - Fork 43
Hide nominate heritage tree section if selected tree is heritage tree #310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
thank you @isabelle-wagenvoord ! please take another look. when I test it, the nomination section still appears in the sidebar for heritage trees. the regular (placeholder) text on the landing page sidebar's also disappeared. to find a heritage tree, you can use the "SM heritage" button. the screenshot is of tree id=10934061 |
c993f98 to
9475a2d
Compare
|
Ah, my bad! Hopefully it should work now. |
…/Public-Tree-Map/public-tree-map into hide-heritage-nomination-section
|
thanks @isabelle-wagenvoord can you please share a screenshot of how it looks when you look at the branch? when I open the index.html file, it looks the same as it did before. thank you again! |
|
@isabelle-wagenvoord I forgot to ask about this PR, I'm sorry! when you test it on your end, do you see the same issues I notice? |
|
Ah my bad @emillipede. I think I forgot to add my changes before committing them 😅. Does it work now? |
|
thanks for the update @isabelle-wagenvoord ! the sidebar placeholder text is visible again when I locally open this branch, but the heritage section of the sidebar still shows up for existing heritage trees when you test the branch, does it look different to you? please let me know. I'm sorry, I don't know what's wrong :( |



resolves #305
What I did
if the selected tree is a heritage tree, then the link to nominate the tree will hide itself.