-
Notifications
You must be signed in to change notification settings - Fork 1.3k
timestep scheduling with np.linspace #8623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ytl0623
wants to merge
6
commits into
Project-MONAI:dev
Choose a base branch
from
ytl0623:fix-issue-8600
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
b96ec40
timestep scheduling with np.linspace
ytl0623 3a2ffc5
remove step_ratio variable
ytl0623 aa3cce6
steps_offset causes out-of-bounds timestep indices
ytl0623 616f5f2
Refactor timesteps calculation in ddim.py
ytl0623 f7ca165
Fix timesteps calculation in ddpm.py
ytl0623 ef7e83c
With the linspace approach, max_timestep = (num_train_timesteps - 1 -…
ytl0623 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -122,10 +122,7 @@ def set_timesteps(self, num_inference_steps: int, device: str | torch.device | N | |
| ) | ||
|
|
||
| self.num_inference_steps = num_inference_steps | ||
| step_ratio = self.num_train_timesteps // self.num_inference_steps | ||
| # creates integer timesteps by multiplying by ratio | ||
| # casting to int to avoid issues when num_inference_step is power of 3 | ||
| timesteps = (np.arange(0, num_inference_steps) * step_ratio).round()[::-1].astype(np.int64) | ||
| timesteps = np.linspace(self.num_train_timesteps - 1, 0, self.num_inference_steps).round().astype(np.int64) | ||
| self.timesteps = torch.from_numpy(timesteps).to(device) | ||
|
Comment on lines
+125
to
126
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Similarly |
||
|
|
||
| def _get_mean(self, timestep: int, x_0: torch.Tensor, x_t: torch.Tensor) -> torch.Tensor: | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this produces the same results in fewer lines.