feat(protocol-designer): Make adjustments to display flex stacker in deck maps #19959
+126
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## edge #19959 +/- ##
==========================================
+ Coverage 24.23% 24.25% +0.02%
==========================================
Files 3540 3536 -4
Lines 298344 298216 -128
Branches 39863 39861 -2
==========================================
+ Hits 72298 72341 +43
+ Misses 226028 225857 -171
Partials 18 18
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
sfoster1
approved these changes
Oct 29, 2025
TamarZanzouri
approved these changes
Oct 29, 2025
koji
reviewed
Oct 29, 2025
Comment on lines
54
to
56
| wholeDeckViewBox = adjustViewBoxForStacker | ||
| ? `${viewBoxOriginX + STACKER_VIEWBOX_ADJUSTMENTS.viewBoxOriginX} ${viewBoxOriginY + STACKER_VIEWBOX_ADJUSTMENTS.viewBoxOriginY} ${deckXDimension + STACKER_VIEWBOX_ADJUSTMENTS.deckXDimension} ${deckYDimension + STACKER_VIEWBOX_ADJUSTMENTS.deckYDimension}` | ||
| : `${viewBoxOriginX} ${viewBoxOriginY} ${deckXDimension} ${deckYDimension}` |
There was a problem hiding this comment.
const base = [viewBoxOriginX, viewBoxOriginY, deckXDimension, deckYDimension] as const
const adj = [
base[0] + STACKER_VIEWBOX_ADJUSTMENTS.viewBoxOriginX,
base[1] + STACKER_VIEWBOX_ADJUSTMENTS.viewBoxOriginY,
base[2] + STACKER_VIEWBOX_ADJUSTMENTS.deckXDimension,
base[3] + STACKER_VIEWBOX_ADJUSTMENTS.deckYDimension,
] as const
const adjustedViewBox = adjustViewBoxForStacker ? adj : base
wholeDeckViewBox = `${adjustedViewBox[0]} ${adjustedViewBox[1]} ${adjustedViewBox[2]} ${adjustedViewBox[3]}`
koji
reviewed
Oct 29, 2025
Comment on lines
135
to
138
| ? deckDef.dimensions[0] + | ||
| (hasFlexStacker | ||
| ? FLEX_STACKER_FIXTURE_PADDING | ||
| : RIGHT_COLUMN_FIXTURE_PADDING) |
There was a problem hiding this comment.
we should avoid using a nested ternary
koji
reviewed
Oct 29, 2025
Comment on lines
119
to
130
| const _getLabwareCompatibleWithFlexStacker = ( | ||
| def: LabwareDefinition2 | ||
| ): boolean => { | ||
| return ( | ||
| RECOMMENDED_LABWARE_BY_MODULE[FLEX_STACKER_MODULE_TYPE].includes( | ||
| def.parameters.loadName | ||
| ) || | ||
| def.metadata.displayCategory === 'wellPlate' || | ||
| def.metadata.displayCategory === 'reservoir' | ||
| ) | ||
| } | ||
|
|
There was a problem hiding this comment.
nit
Suggested change
| const _getLabwareCompatibleWithFlexStacker = ( | |
| def: LabwareDefinition2 | |
| ): boolean => { | |
| return ( | |
| RECOMMENDED_LABWARE_BY_MODULE[FLEX_STACKER_MODULE_TYPE].includes( | |
| def.parameters.loadName | |
| ) || | |
| def.metadata.displayCategory === 'wellPlate' || | |
| def.metadata.displayCategory === 'reservoir' | |
| ) | |
| } | |
| const _getLabwareCompatibleWithFlexStacker = ( | |
| def: LabwareDefinition2 | |
| ): boolean => | |
| ( | |
| RECOMMENDED_LABWARE_BY_MODULE[FLEX_STACKER_MODULE_TYPE].includes( | |
| def.parameters.loadName | |
| ) || | |
| def.metadata.displayCategory === 'wellPlate' || | |
| def.metadata.displayCategory === 'reservoir' | |
| ) |
|
need to tweak the y pos 
|
Ah, this is probably because of the waste chute adjusting the y in the left side. I wonder if we need to build in an additional variable y for the waste chute here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR enables you to add a flex stacker to a PD protocol, properly visualize it on all deck maps, and add compatible labware to the shuttle position.
Test Plan and Hands on Testing
With
enablePrereleaseModeon in PD, turn on the stacking feature flagAdd a stacker to your protocol, play around with the various deck maps and add/remove and move labware on the stacker shuttles
Changelog
Adjust deck thumbnail, zoomed deck map, and deck edit screens to adapt to the stacker's extra footprint (all through manual visual checking unfortunately)
Create list of Stacker recommended and compatible labware for addition in the
Review requests
Test this out!
Risk assessment
Low