-
Couldn't load subscription status.
- Fork 186
docs(Flex): LLD and liquid classes #19806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: edge
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ye olde HTML suggestion included, free!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LLD additions are good. The Introduction refactor needs some additional work, which you can either do here or move to a separate PR, since it's not focused on the LLD feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment, LGTM.
Still think you should use suspended hyphens though. 😜
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## edge #19806 +/- ##
==========================================
+ Coverage 24.23% 25.48% +1.25%
==========================================
Files 3540 3540
Lines 298345 298348 +3
Branches 39863 39863
==========================================
+ Hits 72298 76048 +3750
+ Misses 226029 222276 -3753
- Partials 18 24 +6
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
c744bc6 to
f17a34f
Compare
Overview
reworking the "what's new on Flex" section > "Flex-exclusive features" for a few reasons:
-also sprinkling throughout: LLD, liquid classes, a mention of liquid classes in QT. Trying to bridge the gap before some of these features get more new shiny things added to them and can have their own section (LLD mostly).
Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment