-
Couldn't load subscription status.
- Fork 186
refactor(components): Unify all primary buttons into a single component #19788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
koji
wants to merge
9
commits into
edge
Choose a base branch
from
refactor_unify-buttons
base: edge
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor primary buttons to unify all of them close AUTH-
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## edge #19788 +/- ##
==========================================
- Coverage 25.68% 25.60% -0.09%
==========================================
Files 3515 3519 +4
Lines 294575 294974 +399
Branches 32819 32968 +149
==========================================
- Hits 75662 75519 -143
- Misses 218891 219433 +542
Partials 22 22
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Unify all primary buttons into a single component
[design]
https://www.figma.com/design/1ot18My22DALIcjdLl5LJh/Helix-Design-System?node-id=4811-3035&m=dev
close AUTH-2397
Test Plan and Hands on Testing
run
make -C components devHelix -> atoms -> Button
Changelog
Review requests
Risk assessment
mid since this pr applies the new button component to existing primary buttons