Skip to content

ERC4626: Sweep residual assets on final withdraw to avoid stranded funds #6096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −1
Open

ERC4626: Sweep residual assets on final withdraw to avoid stranded funds #6096

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion contracts/token/ERC20/extensions/ERC4626.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,8 +295,17 @@ abstract contract ERC4626 is ERC20, IERC4626 {
// shares are burned and after the assets are transferred, which is a valid state.
_burn(owner, shares);
_transferOut(receiver, assets);
uint256 withdrawnAssets = assets;
if (totalSupply() == 0) {
uint256 remainingAssets = IERC20(asset()).balanceOf(address(this));
if (remainingAssets > 0) {
// Sweep residual assets so a donation or rounding remainder does not strand funds in the vault.
_transferOut(receiver, remainingAssets);
withdrawnAssets += remainingAssets;
}
}

emit Withdraw(caller, receiver, owner, assets, shares);
emit Withdraw(caller, receiver, owner, withdrawnAssets, shares);
}

/// @dev Performs a transfer in of underlying assets. The default implementation uses `SafeERC20`. Used by {_deposit}.
Expand Down
Loading