Skip to content

Phpstan: some fixes #5009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Phpstan: some fixes #5009

wants to merge 17 commits into from

Conversation

@sreichel
Copy link
Contributor

@sreichel sreichel commented Oct 15, 2025 •
edited
Loading

Fixes arround 100 issues.

[OK] Baseline generated with 1335 errors.

Copilot AI review requested due to automatic review settings October 15, 2025 15:16
@sreichel sreichel added the chore label Oct 15, 2025
@github-actions github-actions bot added Component: PayPal Relates to Mage_Paypal Component: Core Relates to Mage_Core Component: Catalog Relates to Mage_Catalog Component: Reports Relates to Mage_Reports Component: CatalogInventory Relates to Mage_CatalogInventory Component: Checkout Relates to Mage_Checkout Component: lib/Varien Relates to lib/Varien Component: Sales Relates to Mage_Sales Component: Usa Relates to Mage_Usa Component: Customer Relates to Mage_Customer Component: lib/Mage Relates to lib/Mage Component: Adminhtml Relates to Mage_Adminhtml Component: Api PageRelates to Mage_Api Component: Tag Relates to Mage_Tag Component: Api2 Relates to Mage_Api2 Component: ImportExport Relates to Mage_ImportExport Component: ConfigurableSwatches Relates to Mage_ConfigurableSwatches Component: Authorizenet Relates to Mage_Authorizenet Component: lib/* Relates to lib/* phpstan labels Oct 15, 2025
@sreichel sreichel changed the title Phpstan:; some fixes Phpstan: some fixes Oct 15, 2025
@github-actions github-actions bot added the Component: Directory Relates to Mage_Directory label Oct 15, 2025
Copilot AI reviewed Oct 15, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@sreichel sreichel requested a review from Copilot October 15, 2025 17:05
Copilot AI reviewed Oct 15, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 54 out of 54 changed files in this pull request and generated 7 comments.

sreichel and others added 2 commits October 15, 2025 19:39
@sreichel
Update app/code/core/Mage/Core/Model/Domainpolicy.php
88a59cf 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@sreichel
Update app/code/core/Mage/Sales/Model/Recurring/Profile.php
fbe3424 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@sreichel sreichel marked this pull request as draft October 15, 2025 17:47
@github-actions github-actions bot removed the Component: lib/Mage Relates to lib/Mage label Oct 30, 2025
@sreichel sreichel marked this pull request as ready for review October 30, 2025 14:33
@github-actions github-actions bot added the Component: Log Relates to Mage_Log label Oct 30, 2025
@github-actions github-actions bot added Component: Cms Relates to Mage_Cms Component: Cron Relates to Mage_Cron Component: Admin Relates to Mage_Admin Component: Wishlist Relates to Mage_Wishlist Component: Review Relates to Mage_Review Component: Payment Relates to Mage_Payment Component: Oauth Relates to Mage_Oauth Component: Index Relates to Mage_Index Component: Downloadable Relates to Mage_Downloadable Component: CatalogIndex Relates to Mage_CatalogIndex Component: CatalogSearch Relates to Mage_CatalogSearch Component: Dataflow Relates to Mage_Dataflow labels Oct 31, 2025
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
16 New issues
1 Accepted issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.9% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

chore Component: Admin Relates to Mage_Admin Component: Adminhtml Relates to Mage_Adminhtml Component: Api PageRelates to Mage_Api Component: Api2 Relates to Mage_Api2 Component: Authorizenet Relates to Mage_Authorizenet Component: Catalog Relates to Mage_Catalog Component: CatalogIndex Relates to Mage_CatalogIndex Component: CatalogInventory Relates to Mage_CatalogInventory Component: CatalogSearch Relates to Mage_CatalogSearch Component: Checkout Relates to Mage_Checkout Component: Cms Relates to Mage_Cms Component: ConfigurableSwatches Relates to Mage_ConfigurableSwatches Component: Core Relates to Mage_Core Component: Cron Relates to Mage_Cron Component: Customer Relates to Mage_Customer Component: Dataflow Relates to Mage_Dataflow Component: Directory Relates to Mage_Directory Component: Downloadable Relates to Mage_Downloadable Component: ImportExport Relates to Mage_ImportExport Component: Index Relates to Mage_Index Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/* Component: Log Relates to Mage_Log Component: Oauth Relates to Mage_Oauth Component: Payment Relates to Mage_Payment Component: PayPal Relates to Mage_Paypal Component: Reports Relates to Mage_Reports Component: Review Relates to Mage_Review Component: Sales Relates to Mage_Sales Component: Tag Relates to Mage_Tag Component: Usa Relates to Mage_Usa Component: Wishlist Relates to Mage_Wishlist phpstan

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sreichel