Replaced SimpleDateFormat with DateTimeFormatter wherever thread-critical #208
+39
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgaffigan
requested changes
Nov 19, 2025
Contributor
mgaffigan
left a comment
mgaffigan
left a comment
There was a problem hiding this comment.
I agree with changing:
- server/src/com/mirth/connect/client/core/api/providers/CalendarParamConverterProvider.java
- server/src/com/mirth/connect/plugins/serverlog/ServerLogItem.java
but the others are all allocated on the stack - and have no possibility for cross-thread use. Changing DateUtil in particular seems unnecessarily risky.
Also, is there a reason we're jumping to Apache FastDateFormat instead of Java 8 DateTimeFormatter?
NicoPiel
force-pushed
the
bug/replace-simpledateformat
branch
from
9b1257e to
614b02e
Compare
NicoPiel
changed the title
…es only Signed-off-by: Nico Piel <nico.piel@hotmail.de>
Signed-off-by: Nico Piel <nico.piel@hotmail.de>
…ngine#185) Signed-off-by: Nico Piel <nico.piel@hotmail.de>
This script is the main launcher for the Open Integration Engine (OIE)
server. It prepares the Java environment and executes the server launcher
JAR file.
The script automatically finds a compatible Java runtime (version 17+ by
default) by searching for a valid executable in the following priority order:
1. The OIE_JAVA_PATH environment variable.
2. The -java-cmd directive in the oieserver.vmoptions file or included
.vmoptions files. Must specify the path to the 'java' executable.
This is the preferred way to declare the desired version for running
the server and can be overridden by OIE_JAVA_PATH. Can be a relative
path from the location of this script.
3. The JAVA_HOME environment variable.
4. The 'java' command available in the system's PATH.
It also parses the 'oieserver.vmoptions' file to configure JVM options,
system properties (-D...), and classpath modifications.
Signed-off-by: Tony Germano <tony@germano.name>
Co-authored-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
Issue: OpenIntegrationEngine#2
Signed-off-by: Nico Piel <nico.piel@hotmail.de>
This addresses an upsert race condition that occurred when saving plugin properties (e.g., Data Pruner settings, third-party plugins) in environments with a read/write split database configuration where the read-only connection points to a replica. The Problem: The prior code attempted to determine whether to INSERT or UPDATE by first checking for the property's existence using the read-only database connection. Since updating all properties for a plugin involves deleting them all first, if this DELETE operation had not yet propagated to the replica, the read-only check would incorrectly indicate the property still existed. The Result: An UPDATE statement would be attempted, which would fail to match any rows (since the data had already been deleted from the primary) and silently return zero rows updated. This failure was not being checked, leading to data loss for the affected property. The Solution: This change eliminates the preliminary read check. It now attempts an UPDATE first. If the update affects zero rows, a guaranteed INSERT is performed. This pattern ensures atomicity and correctness regardless of replication latency. See https://sqlperformance.com/2020/09/locking/upsert-anti-pattern Issue: Innovar-Healthcare/BridgeLink#66 Signed-off-by: Tony Germano <tony@germano.name> Signed-off-by: Nico Piel <nico.piel@hotmail.de>
Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net> Signed-off-by: Nico Piel <nico.piel@hotmail.de>
Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net> Signed-off-by: Nico Piel <nico.piel@hotmail.de>
Many of the extensions do not include external dependencies, but for consistency in the build file all extensions attempt to copy libs if they exist. The copy tasks were already to configured to not fail if there was an error copying the files (because the source dir does not exist in this case.) This change also sets the quiet option so that a warning is not produced in the build output on a copy error. Signed-off-by: Tony Germano <tony@germano.name> Signed-off-by: Nico Piel <nico.piel@hotmail.de>
Signed-off-by: Tony Germano <tony@germano.name> Signed-off-by: Nico Piel <nico.piel@hotmail.de>
NicoPiel
force-pushed
the
bug/replace-simpledateformat
branch
from
2ce92e1 to
75644de
Compare
Contributor
|
I agree with Mitch
The core Java DateTimeFormatter is rock solid. |
Author
That's why it's implemented :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #207