Lesson6.1 #13
Open
Lesson6.1 #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…updating likes) for both posts & post pages.
…menting post likes. Created store and wrapped App component in Provider.
…prepareData methods to app routes. Created history callback to compare current URL with routes templates and call corresponding prepareData method, hang it onto browserHistory object and added initial call when the app is initialized.
…ols block to DOM, made DevTools component render, added DevTools engancer to redux store.
…stateless. Got rid of BlogPage component & helpers for incrementing likes & interacting with API.
… issue, fixed ownProps issue in PostContainer.
…ng posts list & piechart.
…modules, added processing action for incrementing likes count in post & posts reducers, created LikeContainer. Moved away PagaContainer & added two containers: for PieChart & BlogList.
index01d
approved these changes
Nov 23, 2017
| modified={metaInfo.modified} | ||
| /> | ||
| <LikeContainer | ||
| likes={metaInfo.likes} |
There was a problem hiding this comment.
количество лайков можно получить в контейнере
| _.assign({}, MetaInfo.propTypes, _.pick(Like.propTypes, ['likes'])) | ||
| ), | ||
| like: Like.propTypes.like | ||
| _.assign({}, MetaInfo.propTypes, _.pick(LikeContainer.propTypes, ['likes'])) |
There was a problem hiding this comment.
лучше импортировать конкретные функции (import { assign, pick } from 'lodash'). Так запись здесь будет короче, а в конечный бандл попадут только нужные функции (при применении метода tree-shaking в сборке)
Owner
Author
There was a problem hiding this comment.
Стараюсь уже так делать, надо поубирать где осталось по старому. Спасибо!
Обязателько почитаю про метод tree-shaking в сборке. Не знал об этом.
| like: () => dispatch(incrementLike(ownProps.id)) | ||
| }); | ||
|
|
||
| export default connect(null, actionsToProps)(Like); |
There was a problem hiding this comment.
здесь можно добавить stateToProps и используя ownProps достать количество лайков
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.