Add automated CI workflow for releases #354
Conversation
jfly
left a comment
jfly
left a comment
There was a problem hiding this comment.
Love this, thank you! Left a bunch of nits inline (I learned a bunch about github actions thanks to @infinisil and @MattSturgeon).
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/formatting-team-meeting-2025-11-11/72019/1 |
FlashOnFire
force-pushed
the
release_workflow
branch
6 times, most recently
from
9a8d952 to
4757a52
Compare
jfly
left a comment
jfly
left a comment
There was a problem hiding this comment.
Looking good! Just waiting for #354 (comment) to be resolved and we can land this.
FlashOnFire
force-pushed
the
release_workflow
branch
2 times, most recently
from
87b3682 to
926c4fd
Compare
|
Just waiting for the pipeline to finish on my repo to check if everything works fine, and it should be good to go ! |
|
It works properly on my side, you can check my test release here ! |
jfly
left a comment
jfly
left a comment
There was a problem hiding this comment.
Super close! Just a couple more unsafe interpolations.
FlashOnFire
force-pushed
the
release_workflow
branch
from
926c4fd to
5204483
Compare
3 participants
Follow up PR after #349
Added CI workflow that triggers when a version change is pushed (in nixfmt.cabal) to the master branch.
It automatically builds a static binary, tags the commit, and creates a GitHub release with notes pulled from CHANGELOG.md.
Example release: https://github.com/FlashOnFire/nixfmt/releases/tag/v4.1.0
Edit:
Just thought that, as an alternative, we could have a workflow that triggers when a release is published and simply appends the static binary to it. That way we can keep the release process as-is.
Let me know which option you prefer.